shahar1 commented on PR #68819:
URL: https://github.com/apache/airflow/pull/68819#issuecomment-4808187561

   > I've opened [#68831](https://github.com/astronomer/airflow/issues/68831), 
which fixes the same crash one layer up — at the airflow-core deserialize path 
where that Configuration actually gets attached. The `pod_override` the 
scheduler pickles onto the queue is produced by `BaseSerialization.deserialize 
/ ensure_pod_is_valid_after_unpickling` (via `ExecutorConfigType`), not by the 
executor itself; deserializing there through a fresh `Configuration()` keeps 
the pod (and every nested model) picklable for every consumer of a deserialized 
V1Pod, not just the `KubernetesExecutor` queue. It also gives 
`PodGenerator.deserialize_model_dict` the same treatment, so the provider's 
worker-side reconstruction is covered too.
   > 
   > Since that resolves the crash at the source and makes the executor-level 
reset redundant, I think we can consolidate on 
[#68831](https://github.com/astronomer/airflow/issues/68831) and close this 
one. Let me know if that's reasonable?
   
   @ephraimbuddy The fix is currently in Astronomer's private repo, can you 
please make create a PR in the upstream repo?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to