Ei-Sandi opened a new pull request, #69040:
URL: https://github.com/apache/airflow/pull/69040

   ### Background/Problem
   
   Exponential Histogram metrics was implemented in PR #64207 but the histogram 
metrics are dropped in local dev environment due to outdated Otel Collector and 
Prometheus Version and missing configuration.
   
   ### Changes made
   
   - Otel Collector version is upgraded to latest version `0.155.0` to support 
exponential histogram metrics export feature.
   - Otel Collector config is also updated to support new version (the 
`logging` exporter is renamed to `debug` exporter and the address was set to 
`0.0.0.0` since the default address is `localhost` in later versions).
   - Prometheus version is pinned to `3.5.4` (the latest LTS version). 
   - Feature flag `native-histograms` is set in Prometheus command to support 
exponential histogram.
   
   ### Documentation Update
   
   Requirements are added to support exponential histogram metrics. (The Otel 
Collector, prometheus version requirements and feature flag, configuration 
requirements for prometheus.)
   
   ### Testing
   The changes are manually tested and the histogram metrics are showing up 
locally.
   
   To reproduce the issue locally, run `breeze start-airflow --integration otel 
--load-example-dags` and find `airflow_dag_processing_last_duration` in 
prometheus metrics. Try the same with statsd. Compare the results before and 
after changes.
    
   ### References 
   - https://prometheus.io/docs/specs/native_histograms/
   - https://prometheus.io/docs/prometheus/latest/configuration/configuration/ 
   - https://prometheus.io/download/
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull 
request.
   Write a good git commit message following this guide: 
http://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the 
documentation.
   
   For user-facing UI changes, please attach before/after screenshots (or a 
short
   screen recording) so reviewers can assess the visual impact.
   
   Feel free to ping (in general) for the review if you do not see reaction for 
a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we 
sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [X] Yes (please specify the tool below)
   Claude Opus 4.8 for debugging and Gemini Pro 3.1 for research. 
   
   <!--
   Generated-by: [Tool Name] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to