Vamsi-klu commented on code in PR #68527:
URL: https://github.com/apache/airflow/pull/68527#discussion_r3482669330
##########
providers/databricks/docs/connections/databricks.rst:
##########
@@ -81,6 +81,36 @@ Extra (optional)
* ``token``: Specify PAT to use. Consider to switch to specification of
PAT in the Password field as it's more secure.
+ The following optional parameter can be used when Airflow workers need to
access Databricks or Azure
+ token endpoints through an HTTP proxy:
+
+ * ``proxies``: JSON object with optional ``http`` and ``https`` keys,
using the same shape as the
+ ``requests`` and Azure SDK ``proxies`` argument. Only these two keys are
accepted. The configured proxy
+ is applied to Databricks REST API calls, Databricks OAuth token
exchanges, and Azure Identity token
+ acquisition for AAD and default Azure credential authentication.
+
+ .. code-block:: json
+
+ {
+ "proxies": {
+ "http": "http://proxy.example.com:8080";,
+ "https": "http://proxy.example.com:8443";
+ }
+ }
+
+ **Note:** The ``proxies`` extra is only needed for paths that do not
already pick up the standard
+ ``HTTP_PROXY`` / ``HTTPS_PROXY`` / ``NO_PROXY`` environment variables.
Synchronous REST API and token
+ requests use ``requests``, and Azure AAD / default-credential token
acquisition uses the Azure Identity
+ SDK; both honor those environment variables by default. The asynchronous
(deferrable operator and
+ triggerer) REST API and token paths use ``aiohttp`` with a session that
does **not** trust the
+ environment, so proxy environment variables are ignored there and the
``proxies`` extra is required to
+ proxy them. Use the extra when you need a proxy on the asynchronous
paths, when you want to force a
+ specific proxy regardless of the worker environment, or when only some
endpoints should be proxied.
Review Comment:
Thanks for pointing this out. I updated the Databricks connection docs to
avoid the word `proxied`, since it is not accepted by the docs build/spell
check.
I rephrased both occurrences in
`providers/databricks/docs/connections/databricks.rst` while keeping the
intended meaning the same:
- selected Databricks/Azure endpoints can still use the configured proxy
- the Azure managed-identity path still intentionally bypasses the
configured proxy because it talks to the link-local IMDS endpoint
I also verified that `proxied` no longer appears in the file and ran the
focused docs checks for the updated file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
