onlyarnav commented on PR #69028: URL: https://github.com/apache/airflow/pull/69028#issuecomment-4811993358
Thanks for the update! I just had a look at it. My PR handled the error based on the original issue, where the response appeared to be a plain text string (`resource not found: ...`) rather than a JSON response. Since @stephen-bracken reported the original issue, I only had the information available there and wasn't aware that Keycloak could also return the structured `invalid_resource` JSON response. Now that you shared the sample log, it's much clear. From what you've shared, checking the structured JSON response via `error == "invalid_resource"` looks like a cleaner approach, and it aligns with the log you've posted. My only question is whether the original plain-text `resource not found: ...` response is still possible on any supported Keycloak version or configuration. If that format can still occur, it might be worth handling both cases to avoid a regression. Otherwise, I'm happy with the updated approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
