potiuk commented on issue #68374: URL: https://github.com/apache/airflow/issues/68374#issuecomment-4813466942
Indeed - It does look like dag_maker had not been updated after bundles and teams were added, but IMHO it should - not a "master" of dag_maker, most of my work focuses on executing tests, efficiently - but yes - this is why `dag_maker` was created by @ashb and @uranusjr and @kaxil years ago. That was indeed a fixture used to prepare/clean db for all the tests that require database - so it makes sense to fold-in both bundles and teams in @jedcunningham - i guess the main reason for not doing it for bundles and adding the "clean" methods was that it was somewhat "faster" and more controllable at the time when bundles were created - and it changed over time - but I guess we could do it right now - it would indeed make our tests following similar approach ? That might be a good opportunity BTW to describe it in our contributing docs - around the unit testing docs to document our unit testng patterns. - where we use what and why, document the reasoning why we have dag_maker and other fixtures, because lack of this documentation makes it difficult for both contributors and their agent assisting them to figure out the patterns - especially if they are differing across the codebase. So I would say this change should come as kind of "standardisation and documentation" of the patterns we have. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
