uranusjr commented on code in PR #69058:
URL: https://github.com/apache/airflow/pull/69058#discussion_r3484505611
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##########
@@ -455,13 +471,17 @@ def _change_state(
if state == ADOPTED:
# When the task pod is adopted by another executor,
# then remove the task from the current executor running queue.
+ self.last_known_jobs.pop(key, None)
try:
self.running.remove(key)
except KeyError:
self.log.debug("TI key not in running: %s", key)
return
if state == TaskInstanceState.RUNNING:
+ # The task process started, so any later failure is an execution
failure that should
+ # not be requeued by the pre-execution path below.
+ self.last_known_jobs.pop(key, None)
Review Comment:
These should probably also clean `pod_launch_failure_max_retries`?
I wonder if we should wrap the containers into an object so they are always
handled together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
