uranusjr commented on code in PR #68548: URL: https://github.com/apache/airflow/pull/68548#discussion_r3488026464
########## task-sdk/src/airflow/sdk/coordinators/typescript/coordinator.py: ########## @@ -0,0 +1,158 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""TypeScript runtime coordinator that launches a Node.js subprocess for task execution.""" + +from __future__ import annotations + +import os +import pathlib +from typing import TYPE_CHECKING, Any + +import attrs +import structlog +import yaml + +from airflow.sdk.coordinators._subprocess import SubprocessCoordinator +from airflow.sdk.execution_time.schema import get_schema_version_migrator + +if TYPE_CHECKING: + from collections.abc import Sequence + + from structlog.typing import FilteringBoundLogger + + from airflow.sdk.api.datamodels._generated import TaskInstance + +log: FilteringBoundLogger = structlog.get_logger(logger_name="coordinators.typescript") + +BUNDLE_FILENAME = "bundle.mjs" +METADATA_FILENAME = "airflow-metadata.yaml" Review Comment: A block comment at the and of the mjs would work. I believe this can be done automatically with a build-time plugin (more similar to Java’s Gradle approach). This can be addressed after this PR though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
