uranusjr commented on code in PR #69080:
URL: https://github.com/apache/airflow/pull/69080#discussion_r3488029977
##########
java-sdk/sdk/src/main/kotlin/org/apache/airflow/sdk/execution/Comm.kt:
##########
@@ -109,19 +112,22 @@ class CoordinatorComm(
}
@Throws(ApiError::class)
- suspend fun communicateImpl(body: Any): Any {
- var frame: IncomingFrame? = null
+ suspend fun communicateImpl(body: Any): Any =
+ commMutex.withLock {
+ val requestId = nextId.fetchAndAdd(1)
Review Comment:
I think this should be outside of the lock since `nextId` handles
concurrency itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
