VladaZakharova commented on PR #68930: URL: https://github.com/apache/airflow/pull/68930#issuecomment-4833107027
> 4\. There's no integration for running the tests as part of the CI/CD (which means that we won't be able to detect regressions). Thanks, I agree with both concerns. The reason I proposed keeping it in the Airflow repo is that it is specifically for resources created by Airflow Google provider system tests, not a general Google cleanup utility. Contributors who run those system tests can end up with leftover GCP resources, and having cleanup logic close to the system tests makes it easier to keep handlers updated when tests/operators change. That said, the tool should be usable by any Airflow contributor with their own GCP project, not only the Google team. I updated the PR to remove Google-internal terminology/examples and documented the expected requirements: a GCP project, credentials, Cloud Asset Inventory permissions, and delete permissions for the selected services. Some functionality necessarily requires Google Cloud access, but it should not require Google-internal projects or assumptions. For CI, I agree the previous location was not enough because tests under `tests/system` are ignored by normal pytest collection. I moved the mocked tests into the Google provider unit-test tree so they are collected by provider CI without real GCP access. The tests mock `gcloud`, API calls, and delete handlers, so CI can detect regressions in parsing, dispatching, filtering, protected-resource handling, and cleanup orchestration. I will continue working and updating the PR with time, it is quite big :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
