Lee-W commented on code in PR #69143:
URL: https://github.com/apache/airflow/pull/69143#discussion_r3496725762
##########
airflow-core/tests/unit/timetables/test_interval_timetable.py:
##########
@@ -139,6 +141,84 @@ def test_no_catchup_next_info_starts_at_current_time(
assert next_info == DagRunInfo.interval(start=expected_start,
end=CURRENT_TIME)
[email protected](
+ "last_automated_data_interval",
+ [
+ pytest.param(None, id="first-run"),
+ pytest.param(
+ DataInterval(
+ pendulum.DateTime(2020, 1, 1, tzinfo=utc),
+ pendulum.DateTime(2020, 2, 1, tzinfo=utc),
+ ),
+ id="subsequent",
+ ),
+ ],
+)
[email protected](
+ ("timetable", "start_date", "expected_start", "expected_end"),
+ [
+ pytest.param(
+ MONTHLY_RELATIVEDELTA_TIMETABLE,
+ pendulum.DateTime(2025, 1, 15, tzinfo=utc),
+ pendulum.DateTime(2026, 5, 15, tzinfo=utc),
+ pendulum.DateTime(2026, 6, 15, tzinfo=utc),
+ id="monthly",
+ ),
+ pytest.param(
+ YEARLY_RELATIVEDELTA_TIMETABLE,
+ pendulum.DateTime(2020, 3, 10, tzinfo=utc),
+ pendulum.DateTime(2025, 3, 10, tzinfo=utc),
+ pendulum.DateTime(2026, 3, 10, tzinfo=utc),
+ id="yearly",
+ ),
+ ],
+)
+@time_machine.travel(pendulum.DateTime(2026, 6, 29, tzinfo=utc))
+def test_no_catchup_calendar_delta_aligns_to_start_date(
+ timetable: Timetable,
+ start_date: pendulum.DateTime,
+ expected_start: pendulum.DateTime,
+ expected_end: pendulum.DateTime,
+ last_automated_data_interval: DataInterval | None,
+) -> None:
+ """``catchup=False`` with a relativedelta in months/years must stay aligned
+ to ``start_date`` and not drift onto a fixed 30-day/365-day epoch grid."""
+ next_info = timetable.next_dagrun_info(
+ last_automated_data_interval=last_automated_data_interval,
+ restriction=TimeRestriction(earliest=start_date, latest=None,
catchup=False),
+ )
+ assert next_info == DagRunInfo.interval(start=expected_start,
end=expected_end)
+
+
+@time_machine.travel(pendulum.DateTime(2026, 6, 29, 12, tzinfo=utc))
+def test_no_catchup_calendar_delta_without_start_date_ends_now() -> None:
+ """With no ``start_date`` to anchor on, the interval simply ends at now."""
+ next_info = MONTHLY_RELATIVEDELTA_TIMETABLE.next_dagrun_info(
+ last_automated_data_interval=None,
+ restriction=TimeRestriction(earliest=None, latest=None, catchup=False),
+ )
+ assert next_info == DagRunInfo.interval(
+ start=pendulum.DateTime(2026, 5, 29, 12, tzinfo=utc),
+ end=pendulum.DateTime(2026, 6, 29, 12, tzinfo=utc),
+ )
+
+
+@time_machine.travel(pendulum.DateTime(2026, 6, 29, tzinfo=utc))
+def test_no_catchup_calendar_delta_uses_one_period_at_a_time_clamping() ->
None:
+ """Boundaries must follow relativedelta day-clamping period by period
+ (Jan 31 -> Feb 28 -> Mar 28 ...), not a multiplied jump off
``start_date``."""
Review Comment:
```suggestion
(Jan 31 -> Feb 28 -> Mar 28 -> ... -> May 28 -> ...), not a multiplied
jump off ``start_date``."""
```
I was confused at the first glance. I don't think I'm extending this
docstring in the right way, but we should do something similair 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
