parkhojeong commented on code in PR #66846:
URL: https://github.com/apache/airflow/pull/66846#discussion_r3493889262
##########
scripts/in_container/run_check_airflow_import_smoke.py:
##########
Review Comment:
Thanks for the look.
When I found the broken import, I considered adding coverage to prevent a
similar issue from happening again. I also added this check to the script to
get feedback on whether it belongs in CI or prek.
However, most of the logic in Airflow is already covered by tests, so adding
the separate test just to verify the runtime import does not seem worth it.
I think adding a unit test for TaskHandlerWithCustomFormatter is enough for
now. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
