arkadiuszbach commented on code in PR #69034:
URL: https://github.com/apache/airflow/pull/69034#discussion_r3504613404
##########
chart/files/pod-template-file.kubernetes-helm-yaml:
##########
@@ -106,6 +106,15 @@ spec:
env:
- name: AIRFLOW__CORE__EXECUTOR
value: {{ .Values.executor | quote }}
+ # Deliver pod-termination signals only to the task supervisor
(dumb-init's
+ # direct child), not to the whole process group. This lets a running
task
+ # finish on graceful pod shutdown -- the same warm-shutdown mechanism
Celery
+ # workers use -- instead of being killed by dumb-init's group-wide
broadcast,
+ # and removes the boot-time race where a SIGTERM could reach the task
before
+ # its handler is installed. Hard kills (heartbeat loss / overtime / the
+ # post-grace SIGKILL) are unaffected.
Review Comment:
Adjusted the comment a bit, found that for Celery, DUMB_INIT_SETSID=0 is
described in `docker-stack-docs/entrypoint.rst`, so added the task pods part
there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
