Lee-W commented on code in PR #68778:
URL: https://github.com/apache/airflow/pull/68778#discussion_r3504726344
##########
airflow-core/src/airflow/partition_mappers/base.py:
##########
@@ -37,6 +38,12 @@ class PartitionMapper(ABC):
"""
is_rollup: ClassVar[bool] = False
+ #: Rerun handling does not apply to a non-rollup mapper, so the base
default
+ #: is ``RerunPolicy.NONE``. :class:`RollupMapper` sets it per instance, so
the
+ #: scheduler can read ``mapper.rerun_policy`` uniformly without a rollup
+ #: type-check. (An instance attribute with a class default, not a
ClassVar, so
+ #: RollupMapper can assign to it.)
Review Comment:
IIRC, this is used by Sphinx. It's used in a few places. In core,
`airflow/sdk/execution_time/context.py` NEVER_EXPIRE and
`expected_decoded_type` in partition mapper. I feel this is something new. We
can remove it altogether if not desired 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
