karenbraganz commented on code in PR #65618:
URL: https://github.com/apache/airflow/pull/65618#discussion_r3506532396
##########
providers/common/sql/src/airflow/providers/common/sql/triggers/sql.py:
##########
@@ -17,21 +17,32 @@
# under the License.
from __future__ import annotations
+import importlib
+import sys
from typing import TYPE_CHECKING
+from asgiref.sync import sync_to_async
+
from airflow.providers.common.compat.sdk import AirflowException, BaseHook
from airflow.providers.common.compat.version_compat import AIRFLOW_V_3_2_PLUS
+from airflow.providers.common.sql.hooks.handlers import fetch_all_handler
from airflow.providers.common.sql.hooks.sql import DbApiHook
from airflow.triggers.base import BaseTrigger, TriggerEvent
if TYPE_CHECKING:
from collections.abc import AsyncIterator
from typing import Any
+from collections.abc import (
+ Iterable,
+ Mapping,
+ Sequence,
+)
-class SQLExecuteQueryTrigger(BaseTrigger):
+
+class SQLGenericTransferTrigger(BaseTrigger):
Review Comment:
@kacpermuda previously, the GenericTransfer operator used a trigger called
the SqlExecuteQueryTrigger. Now that I am making the SqlExecuteQueryOperator
deferrable, I thought it would be confusing to have a SqlExecuteQueryTrigger
that is actually used by a different operator. I renamed the trigger used by
the GenericTransfer operator to SqlGenericTransferTrigger and used the
SqlExecuteQueryTrigger name for the trigger used by the SqlExecuteQueryOperator.
This name change is not required, but is good for consistency between the
trigger and operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
