potiuk commented on issue #7023: Remove {table} line 94
URL: https://github.com/apache/airflow/pull/7023#issuecomment-570644835
 
 
   Few issues:
   
   1) Please follow the 
https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines
 including updating PR description
   2) You seem to be removing a feature from s3/redshift operator. The operator 
supports reading from key/table and you seem to not care about the table. If 
you want to add this feature you should modify the operator to support both 
with and without table.
   3) There should be unit tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to