shahar1 commented on code in PR #68800:
URL: https://github.com/apache/airflow/pull/68800#discussion_r3508237662
##########
providers/cncf/kubernetes/tests/unit/cncf/kubernetes/executors/test_kubernetes_executor.py:
##########
@@ -1726,6 +1728,72 @@ def test_get_task_log(self, mock_get_kube_client,
create_task_instance_of_operat
"Reading from k8s pod logs failed: error_fetching_pod_log",
]
+ def test_init_does_not_create_manager_process(self):
+ """
+ Constructing the executor must not spawn a ``multiprocessing.Manager``.
+
+ The API server builds a ``KubernetesExecutor`` purely to call
``get_task_log()`` for
+ RUNNING tasks and never starts it. Eagerly creating the Manager in
``__init__`` leaked an
+ orphaned ``serve_forever`` process per API-server worker.
+ """
Review Comment:
I want to merge this PR to include it in the upcoming ad-hoc release, it
could be handled in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
