Lee-W commented on code in PR #68883:
URL: https://github.com/apache/airflow/pull/68883#discussion_r3510972259
##########
airflow-core/src/airflow/models/backfill.py:
##########
@@ -123,6 +123,17 @@ class InvalidBackfillConf(AirflowException):
"""
+class NoBackfillRunsToCreate(ValueError):
Review Comment:
Yep, I noticed this but still decided to make it `ValueError` instead of
`AirflowException`. The reason is just to reduce `AirflowException` usage.
Using it directly is definitely a no. Inheriting from it is somewhat ok, but I
don't like it as much. It prevents us from removing `AirflowException` if we
want to do so someday, while we have no risk of using `ValueError` (I hope
Python's not actaully doing it...).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
