phanikumv commented on code in PR #69079:
URL: https://github.com/apache/airflow/pull/69079#discussion_r3511031038
##########
task-sdk/src/airflow/sdk/execution_time/schema/schema.json:
##########
@@ -4515,6 +4515,18 @@
"format": "date-time",
"title": "Timestamp",
"type": "string"
+ },
+ "partition_key": {
+ "anyOf": [
+ {
+ "type": "string"
+ },
+ {
+ "type": "null"
+ }
+ ],
+ "default": null,
+ "title": "Partition Key"
Review Comment:
`partition_key` is added to `AssetEventDagRunReference` in this generated
snapshot. Checked the actual Pydantic models (`_generated.py:713`,
`taskinstance.py:309`, and the `AssetEventDagRunReferenceResult`
subclass in `comms.py:450`) - none of them declare this field, and I
regenerated the snapshot locally to confirm: the field disappears entirely on a
clean regen.
It's harmless at runtime (optional, never populated from the wire), but
`generate-supervisor-schemas-snapshot` (it keeps
task-`sdk/src/airflow/sdk/execution_time/schema/schema.json` in sync with the
actual Pydantic models) will go red on this PR since the diff also touches
`comms.py/processor.py`, which trigger it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
