potiuk commented on code in PR #69308: URL: https://github.com/apache/airflow/pull/69308#discussion_r3519415001
########## scripts/ci/prek/check_eval_reminder.py: ########## @@ -0,0 +1,58 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Remind contributors to run skill-eval when guidance files change. + +This hook prints a warning when AGENTS.md or SKILL.md is staged for +commit. It always exits 0 — it never blocks the commit. Review Comment: I am not sure if that is going to be enough of a nudge. I think what we could do instead is to have somewhere a proof that the evals have been run after the change. That woud likely be a good idea to make a pre-push prek hook that verifies that (and failing in CI in case the proof is not there). This could be done rather simply: * calculate consistent hash of all the input AGENTS.md and related files * when you run eval and it succeeds -> store the hash in "Last succesufl eval run hash". * the prek hook should verify if the hashes match -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
