srchilukoori commented on PR #65840: URL: https://github.com/apache/airflow/pull/65840#issuecomment-4877874726
> Thanks for the update — the version concern from my last pass is resolved: it's now `__version__ = "0.3.11"` and the dependency has moved from the URL-pinned wheel to the workspace member (`sphinx-airflow-theme>=0.3.11`), so `fetch_theme_assets.py` no longer resolves a stale/older asset. Good. > > One thing before this can move: the branch is currently conflicting with `main` (`DIRTY`), so please **rebase onto latest `main`**. The two failing checks (`Latest Boto` and `Pendulum2` provider tests) are unrelated to a docs-theme change and look like stale-base fallout — a rebase should clear both. Once it's rebased and green, ping me for a full re-review of the workspace-member wiring. > > Not approving in the meantime — purely the rebase, not the approach. > > > _This review was drafted by an AI-assisted tool and confirmed by an Airflow maintainer. The findings below are observations, not blockers; an Airflow maintainer — a real person — will take the next look at the PR. If you think a finding is mis-applied, please reply on the PR and a maintainer will weigh in._ > > _More on how Airflow handles maintainer review:_ [contributing-docs/05_pull_requests.rst](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst). rebased the branch and resolved the conflicts. ci tests are running now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
