kaxil commented on code in PR #68260:
URL: https://github.com/apache/airflow/pull/68260#discussion_r3520982941
##########
providers/common/ai/src/airflow/providers/common/ai/plugins/www/vite.config.ts:
##########
@@ -41,17 +41,13 @@ export default defineConfig(({ command }) => {
"react",
"react-dom",
"react/jsx-runtime",
Review Comment:
Now that Chakra isn't external, the plugin bundles its own copy, but
`main.tsx` still reads the host's `ChakraUISystem` global and feeds it into
this bundled `ChakraProvider`, so a system created by the host's Chakra gets
consumed by a different Chakra copy. The repro core (3.1.7) never sets that
global (it falls back to `localSystem`), so the before/after screenshots don't
cover this path. Worth verifying that host theme and dark-mode still inherit on
a current core, especially since the plugin pins `^3.34.0` while the host uses
`~3.34.0`, so the two can drift apart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
