anishgirianish commented on PR #69342: URL: https://github.com/apache/airflow/pull/69342#issuecomment-4881158843
> So I had a look at all instances of `clear_db_teams()` and `clear_db_dag_bundles()` in `airflow-core/tests/unit/models` and could only find this one instance in the `reset_db` fixture in `test_xcom.py` that could potentially be removed. Is there a reason this one still needs to remain, or was it just missed? My suspicion is that it is used in mutliple place (not just limited to the setup methods where this is needlessly defensive). Is that true? > > Besides that, everything else looks good. There is a CI failure but that could just be fixed with a rebase. Looks unrelated to these specific test adjustments. Thanks Great catch. I chekeced and can't just delete it though, the fixture has no teardown so the testing bundle from sync_dag_to_db would leak. Moved it to teardown instead. Pushed. Please let me know your thoughts on this. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
