t oo created AIRFLOW-6443:
-----------------------------
Summary: Pool name - increase length > 50, make cli give error if
too large
Key: AIRFLOW-6443
URL: https://issues.apache.org/jira/browse/AIRFLOW-6443
Project: Apache Airflow
Issue Type: Improvement
Components: scheduler
Affects Versions: 1.10.3
Reporter: t oo
Assignee: Ash Berlin-Taylor
Fix For: 1.10.4
create some pool names (using cli) with 70 or 80 character length
Q 1. UI does not allow creating > 50 length but why does cli?
[https://domain:8080/admin/pool/]
click on one of the pool names listed (link is cut to 50 char name:
[https://domain:8080/admin/airflow/task?flt1_pool_equals=qjfdal_CRCE_INTERCONNECTION_FORECAST_TNC_EJFLSA_LP)]
get below error:
[2019-04-15 22:40:12,554] \{app.py:1761} ERROR - Exception on
/admin/airflow/task [GET]
Traceback (most recent call last):
File "/home/ec2-user/venv/local/lib64/python2.7/site-packages/flask/app.py",
line 2292, in wsgi_app
response = self.full_dispatch_request()
File "/home/ec2-user/venv/local/lib64/python2.7/site-packages/flask/app.py",
line 1815, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/home/ec2-user/venv/local/lib64/python2.7/site-packages/flask/app.py",
line 1718, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/home/ec2-user/venv/local/lib64/python2.7/site-packages/flask/app.py",
line 1813, in full_dispatch_request
rv = self.dispatch_request()
File "/home/ec2-user/venv/local/lib64/python2.7/site-packages/flask/app.py",
line 1799, in dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File
"/home/ec2-user/venv/local/lib64/python2.7/site-packages/flask_admin/base.py",
line 69, in inner
return self._run_view(f, *args, **kwargs)
File
"/home/ec2-user/venv/local/lib64/python2.7/site-packages/flask_admin/base.py",
line 368, in _run_view
return fn(self, *args, **kwargs)
File
"/home/ec2-user/venv/local/lib64/python2.7/site-packages/flask_login/utils.py",
line 261, in decorated_view
return func(*args, **kwargs)
File
"/home/ec2-user/venv/local/lib/python2.7/site-packages/airflow/www/utils.py",
line 275, in wrapper
return f(*args, **kwargs)
File
"/home/ec2-user/venv/local/lib/python2.7/site-packages/airflow/www/views.py",
line 893, in task
dttm = pendulum.parse(execution_date)
File
"/home/ec2-user/venv/local/lib64/python2.7/site-packages/pendulum/parser.py",
line 75, in parse
return Parser(**options).parse(text)
File
"/home/ec2-user/venv/local/lib64/python2.7/site-packages/pendulum/parser.py",
line 31, in parse
parsed = super(Parser, self).parse(text)
File
"/home/ec2-user/venv/local/lib64/python2.7/site-packages/pendulum/parsing/parser.py",
line 297, in parse
return self.normalize(self._parse(text))
File
"/home/ec2-user/venv/local/lib64/python2.7/site-packages/pendulum/parsing/parser.py",
line 342, in _parse
parsed = self.parse_common(text)
File
"/home/ec2-user/venv/local/lib64/python2.7/site-packages/pendulum/parsing/parser.py",
line 104, in parse_common
m = self.COMMON.match(text)
TypeError: expected string or buffer
If click 'edit' it shows full 80chars in Description but cut 50chars in Pool
Q2. why this large error? i believe its related to the fact that this is new
airflow instance where no DAGs/tasks have run yet so it is expecting some
execution_date value but none is there. Confirmed this as creating a new 3
letter pool name still gives the large error after clicking on the name of the
created pool
Q3. why limit to 50 length at all?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
