anxkhn opened a new pull request, #69406:
URL: https://github.com/apache/airflow/pull/69406
The `test_run_sql` case in the Alibaba provider asserted
`mock_client.run_sql.asssert_called_once_with(...)` with a misspelled
`asssert`
(three s's). On a `MagicMock`, that attribute is auto-created as a child
mock, so
calling it returns a truthy mock and the wrapping `assert` always passed.
This is
the only assertion of `MaxComputeHook.run_sql`'s argument forwarding to
`client.run_sql`, so the forwarded keyword arguments were never actually
checked,
including the branch that derives `priority` from the
`odps.instance.priority`
hint when no explicit priority is given.
This replaces the no-op with a real `assert_called_once_with` (a bare
statement,
matching the sibling `test_get_instance` / `test_stop_instance_success`
cases) and
parametrizes the test over three cases so the forwarded arguments are
genuinely
verified:
- `explicit-priority`: an explicit `priority` is forwarded unchanged
(derivation
branch not taken).
- `priority-from-hints`: `priority=None` with
`hints={"odps.instance.priority": 5}`
is derived to `5` (derivation branch taken, previously untested).
- `no-priority`: `priority=None` and `hints=None` stays `None`.
Test-only change. Confirmed red -> green: correcting the assertion turns it
from
always-passing into a real check, and disabling the derivation branch in the
hook
makes only the `priority-from-hints` case fail. `rg "asssert"` across the
repo now
returns zero matches.
---
##### Was generative AI tooling used to co-author this PR?
- [ ] Yes (please specify the tool below)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
