potiuk opened a new pull request, #69419:
URL: https://github.com/apache/airflow/pull/69419

   `monaco-editor` 0.53 removed the internal `codiconStyles` side-effect module 
that the local ESM Monaco setup imported to register the codicon glyph font 
(folding arrows, find-widget icons). This imports the two stylesheets that 
module pulled in — `codicon/codicon.css` and `codicon/codicon-modifiers.css` — 
directly instead, mirroring the existing dynamic-CSS-import pattern already 
used for Katex (`KatexStyleLoader.ts`).
   
   Both files ship in the currently pinned `0.52.2` and in newer releases, so 
this is behaviour-neutral today and unblocks the pending `monaco-editor` bump 
to 0.55.x (dependabot #69354 / the v3-3-test #69355), which otherwise fails the 
React UI tests with:
   
   ```
   Failed to resolve import 
"monaco-editor/esm/vs/base/browser/ui/codicons/codiconStyles"
   ```
   
   ### Verified locally
   - monaco 0.52.2 + fix → affected tests pass (no regression)
   - monaco 0.55.1 **without** fix → reproduces the exact CI failure above
   - monaco 0.55.1 **with** fix → affected tests pass (32/32)
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 4.8)
   
   Generated-by: Claude Code (Opus 4.8) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to