pierrejeambrun commented on code in PR #68777:
URL: https://github.com/apache/airflow/pull/68777#discussion_r3529351341


##########
airflow-core/src/airflow/api_fastapi/execution_api/datamodels/connection_test.py:
##########
@@ -46,5 +46,5 @@ class ConnectionTestConnectionResponse(BaseModel):
     login: str | None = None
     password: str | None = None
     schema_: str | None = Field(None, alias="schema")
-    port: int | None = None
+    port: int | None = Field(default=None, ge=0, le=65535)

Review Comment:
   ? That's a response and will break existing stuff. Only 'Body', this should 
be in ConnectionTestRequestBody



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to