Dev-iL opened a new pull request, #69476:
URL: https://github.com/apache/airflow/pull/69476
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
related:
- #68453
depends on:
- #69469
The hardcoded fallback that derives `[celery] result_backend` from
`sql_alchemy_conn` when a driverless `postgresql://` URL is configured targeted
`postgresql+psycopg2://` explicitly. Update it to match the new sync Postgres
driver default.
### What changed
-
`providers/celery/src/airflow/providers/celery/executors/default_celery.py`:
the result-backend URL derivation now targets `postgresql+psycopg://` when
psycopg (v3) is actually usable, falling back to `postgresql+psycopg2://`
otherwise. A new `_USE_PSYCOPG3` check (`psycopg` importable AND SQLAlchemy ≥
2.0.0) gates this — `providers/celery` declares no dependency on psycopg or
SQLAlchemy 2.0, so an unconditional switch would have silently broken the
derivation under Airflow's lowest-dependency-resolution CI job.
- `providers/celery/src/airflow/providers/celery/get_provider_info.py`:
example connection string updated to `db+postgresql+psycopg://...`.
- `providers/celery/docs/changelog.rst`: note describing the result-backend
URL default change as user-facing.
### Test plan
- `providers/celery/tests/unit/celery/executors/test_celery_executor.py`:
`test_result_backend_derived_from_sql_alchemy_conn_uses_psycopg` asserts the
new `postgresql+psycopg` scheme (via `monkeypatch.setattr(default_celery,
"_USE_PSYCOPG3", True)`, not `importlib.reload`, to stay deterministic
regardless of what's actually installed in the test environment). New
`test_result_backend_falls_back_to_psycopg2_without_psycopg3` covers the
opposite path.
- Both tests run and pass; deterministic under lowest-dependency-resolution
conditions since neither depends on ambient package availability.
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
Generated-by: Claude Code Sonnet 5 following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
