ferruzzi commented on code in PR #69092:
URL: https://github.com/apache/airflow/pull/69092#discussion_r3531304282
##########
providers/celery/tests/unit/celery/executors/test_celery_executor.py:
##########
@@ -216,6 +216,64 @@ def test_gauge_executor_metrics(self, mock_stats_gauge,
mock_trigger_tasks, mock
]
mock_stats_gauge.assert_has_calls(calls)
+ @pytest.mark.backend("mysql", "postgres")
Review Comment:
Do we actually need this mocked backend for our new test?
##########
providers/celery/src/airflow/providers/celery/executors/celery_executor.py:
##########
@@ -210,7 +211,7 @@ def _send_workloads(self, workload_tuples_to_send:
Sequence[WorkloadInCelery]):
):
retries = self.workload_publish_retries[key]
if retries < self.workload_publish_max_retries:
Review Comment:
Amazon and K8S both needed
```
if not hasattr(self, "team_name"):
self.team_name = None
```
for backcompat for environments running Airflow < 3.1. Since Celery also
supports `apache-airflow>=2.11.0` I'm pretty sure this does too, unless you
know of a reason it doesn't?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
