Dev-iL opened a new pull request, #69491:
URL: https://github.com/apache/airflow/pull/69491
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
related:
- #68453
- https://github.com/apache/airflow/issues/69443
depends on:
- #69474
`from pgvector.psycopg2 import register_vector` ran unconditionally at
module level in `PgVectorIngestOperator`, forcing psycopg2 to be importable
regardless of which driver the underlying `PostgresHook` connection actually
uses. Make the import lazy and raise a clear, actionable error if it's
genuinely needed but missing.
> **Note:** this module only imports cleanly without psycopg2 installed once
`apache-airflow-providers-postgres` itself stops hard-requiring psycopg2 —
that's the companion change in **psycopg3-sync-postgres**. This PR should be
merged after (or at least released alongside) that one; see the code comment at
the import site and in the test file.
This does **not** fix a separate, pre-existing bug where `register_vector`
is always called with the psycopg2-specific helper regardless of whether the
connection is actually psycopg2 or psycopg3 — that's tracked separately at
apache/airflow#69443, referenced in a code comment at the guard site so it
isn't lost.
### What changed
- `providers/pgvector/src/airflow/providers/pgvector/operators/pgvector.py`:
`from pgvector.psycopg2 import register_vector` moved inside
`_register_vector()`, guarded with `AirflowOptionalProviderFeatureException` if
`pgvector.psycopg2`/psycopg2 is unavailable.
### Test plan
- New tests: `test_register_vector_raises_clear_error_without_psycopg2`,
`test_pgvector_module_imports_without_psycopg2` (simulates psycopg2 absent via
`sys.modules` patching, confirms clean import and a clear error on actual use).
- Existing `register_vector`-mocking tests still pass; a code comment
documents that they currently rely on psycopg2 staying installed in this
provider's dev environment until the postgres provider's `[psycopg2]` extra
exists to depend on explicitly.
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
Generated-by: Claude Code (Sonnet 5) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
* * * *
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
