Lee-W commented on code in PR #67104:
URL: https://github.com/apache/airflow/pull/67104#discussion_r3533602486
##########
airflow-core/src/airflow/logging_config.py:
##########
@@ -120,6 +120,39 @@ def load_logging_config() -> tuple[dict[str, Any], str]:
) or DEFAULT_LOGGING_CONFIG_PATH
+def _warn_if_missing_remote_task_log(logging_class_path: str) -> None:
+ """
+ Warn if ``[logging] remote_logging`` is on but the user module exposes no
remote IO.
+
+ Runs *after* ``dictConfig`` has constructed handlers, so deprecated
+ self-registration in provider task handlers (Elasticsearch, OpenSearch) has
+ already had its chance to populate
``_ActiveLoggingConfig.remote_task_log``.
+ Only fires for user-defined ``logging_config_class`` values; the stock
+ fallback is exempt.
+
+ :param logging_class_path: the resolved ``[logging] logging_config_class``
+ dotted path (already defaulted to :data:`DEFAULT_LOGGING_CONFIG_PATH`).
+ """
+ user_defined = bool(logging_class_path) and logging_class_path !=
DEFAULT_LOGGING_CONFIG_PATH
Review Comment:
But isn't it user-defined? User defined it as "". It could be an invalid
definition, but it's technically user_defined. I do not oppose this logic that
much. but if we're to keep it, we'd better rename the variable or add proper
comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
