uranusjr commented on code in PR #69444: URL: https://github.com/apache/airflow/pull/69444#discussion_r3534331417
########## java-sdk/README.md: ########## @@ -116,6 +122,30 @@ projectVersion=1.0.0 Commit the change and push it to the release branch. +Use a Maven-compatible version string, as defined by the +[Maven version order specification](https://maven.apache.org/pom.html#Version_Order_Specification). +For example, version 1 beta 1 is `1.0.0-beta1`, and the eventual +general-availability release is `1.0.0`. + +*NOTE:* Editing `gradle.properties` as above is the standard procedure. You can +alternatively override the version for a single command without editing the +file, by passing `-PprojectVersion=1.0.0-beta1` to any Gradle invocation. This +is handy for one-off or pre-release builds. Either way, `main` should stay on a +`-SNAPSHOT` version between releases: a snapshot sorts after `1.0.0-beta1` and +before the `1.0.0` GA, so no extra bump is needed after a beta. + +### Tag the release candidate + +Tag the release commit, keeping the RC number in the tag name so a failed vote +simply bumps to the next RC (the artifact version itself does not carry the RC +suffix). Push the tag before sending the vote so reviewers can check out the +exact source being voted on. + +```bash +git tag -s java-sdk/1.0.0-beta1-rc1 -m "Java SDK 1.0.0-beta1 RC 1" +git push origin java-sdk/1.0.0-beta1-rc1 Review Comment: Caught me not following the convention. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
