amoghrajesh commented on PR #69524: URL: https://github.com/apache/airflow/pull/69524#issuecomment-4901238786
@eladkal thanks for your comment, i went through a bit and this isn't Redshift specific. I checked the rest of `providers/amazon` for the same shape (`deferrable` silently defeated by another flag, no warning) and found it in 6 more operators across 2 files: - `dms.py`: `DmsModifyTaskOperator`, `DmsDeleteReplicationConfigOperator`, `DmsStartReplicationOperator`, `DmsStopReplicationOperator` - `redshift_cluster.py`: `RedshiftResumeClusterOperator`, `RedshiftPauseClusterOperator`, these are actually worse, since `wait_for_completion` defaults to `False` there, so `deferrable=True` is a no-op out of the box, not just in an edge-case combination. Given the scope, I suggest keeping this PR focused on `RedshiftDataOperator` and tracking the other 6 operators as separate follow-up work rather than expanding this PR to touch unrelated operators. Happy to open a tracking issue for that if useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
