seanmuth commented on PR #69489: URL: https://github.com/apache/airflow/pull/69489#issuecomment-4905390554
Thanks for the review! Pushed `3c0560208b` addressing all the points: - **Target version** — retargeted the migration to 3.4.0: renamed to `0124_3_4_0_…`, `airflow_version="3.4.0"`, restored the `3.3.0` head and added a `3.4.0` entry in `REVISION_HEADS_MAP`, and updated the migration ref doc. - **Newsfragment** — removed; agreed this isn't a behaviour change that needs a user warning. - **Description** — trimmed to just the exact-match / indexed-equality note, dropped the comparison to the search params (they have their own docs). - **Multiple values** — `uri` now accepts repeated params (`?uri=a&uri=b`) via `FilterParam[list[str]]` + `ANY_EQUAL` + `default_factory=list`, following the `QueryTIStateFilter` pattern. Added a test covering it. Agreed a list endpoint accepting multiple values is the right shape here. - **ORM comment** — removed the API-layer reference from the model; kept the index (thanks for confirming 2.x had one). Regenerated the OpenAPI spec + UI client. Locally the asset filter tests (14) and a fresh-DB up → down → up migration check both pass. --- Drafted-by: Claude Code (Opus 4.8, 1M context) (no human review before posting) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
