Dev-iL opened a new pull request, #69563:
URL: https://github.com/apache/airflow/pull/69563
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
Fixes a flaky unit test in
`TestAsyncPodManager::test_fetch_container_logs_before_current_sec_various_logs`.
The parametrize data built each log line's timestamp and the test's `now`
value from separate `pendulum.now()` calls made at collection time. When those
calls happened to straddle a second boundary, the "timestamp equal to the
current second" cases (3 and 6) would intermittently fail, because the values
were no longer equal once truncated to the second — even though the test
assumed they always would be.
This surfaced as an intermittent CI failure:
```
FAILED
providers/cncf/kubernetes/tests/unit/cncf/kubernetes/utils/test_pod_manager.py::TestAsyncPodManager::test_fetch_container_logs_before_current_sec_various_logs[log_lines5-now5-expected_log_messages5-not_expected_log_messages5]
- AssertionError: assert call(20, '[%s] %s', 'base', 'msg2') not in [call(20,
'[%s] %s', 'base', 'msg1'), call(20, '[%s] %s', 'base', 'msg2')]
```
The fix removes the wall-clock dependency: each parametrize case now
specifies log-line timestamps as second offsets (or `None` for a continuation
line with no timestamp) relative to a single fixed reference instant
(`pendulum.datetime(2024, 1, 1, 12, 0, 0)`) that the test body builds and mocks
`pendulum.now()` to return. This guarantees the "equal to now" cases are always
exactly equal to the second, regardless of how fast or slow the test runs.
Verified the previously-flaky test 20x in a row locally with no failures,
and confirmed the failure reproduces identically on `main` without this change
(i.e., unrelated to any in-flight work).
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
Generated-by: Claude Code (Sonnet 5) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
