o-nikolas commented on code in PR #69109:
URL: https://github.com/apache/airflow/pull/69109#discussion_r3540265201
##########
providers/openlineage/src/airflow/providers/openlineage/utils/utils.py:
##########
@@ -980,9 +985,12 @@ class DagRunInfo(InfoJsonEncodable):
"dag_bundle_version": lambda dagrun:
DagRunInfo.dag_version_info(dagrun, "bundle_version"),
"dag_version_id": lambda dagrun: DagRunInfo.dag_version_info(dagrun,
"version_id"),
"dag_version_number": lambda dagrun:
DagRunInfo.dag_version_info(dagrun, "version_number"),
+ "dag_team_name": lambda dagrun: DagRunInfo.team_name(dagrun) if
AIRFLOW_V_3_3_PLUS else None,
"deadlines": lambda dagrun: DagRunInfo.deadlines(dagrun),
}
+ _team_name_cache: ClassVar[dict[str, str | None]] = {}
Review Comment:
Do we really need the cache in that case honestly? If we're counting on this
only executing in a temporary fork where only one or two calls will be cached,
is it providing that much value? Or just more surface for something to go wrong
in other code paths/code reuse? I'd vote to simplify where we can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
