Vamsi-klu commented on PR #69544: URL: https://github.com/apache/airflow/pull/69544#issuecomment-4912281827
Verified both hunks against head. In supervisor.py the handler is log.exception(...) then raise, and for_queue only raises Exception subclasses (InvalidCoordinatorError/ValueError, plus any failure from the dynamically import_string-loaded coordinator class), so narrowing bare except: to except Exception: is behavior-preserving for every real error. The only runtime effect is that KeyboardInterrupt/SystemExit no longer get an extra traceback logged on their way out -- note they were already re-raised by the `raise` under the old bare except, so this suppresses a spurious log line rather than fixing swallowed signals. In pytest_plugin.py the removed except: raise was a pure no-op and the finally restoring AIRFLOW_CONFIG runs regardless, so removal is identical. Correct and cherry-pickable, just low impact. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
