henry3260 opened a new pull request, #69612: URL: https://github.com/apache/airflow/pull/69612
## Why `MetastorePartitionSensor` documents `mysql_conn_id` as the connection argument and is intended to generate the Hive metastore partition query internally. After inheriting from `SqlSensor`, the documented constructor path still required callers to pass the parent `conn_id` and `sql` arguments manually, so normal usage did not match the public API. The sensor also interpolated templated table, schema, and partition values directly into the SQL string. Passing those values through SQL parameters keeps the query construction aligned with `SqlSensor` behavior. ## What - Updated `providers/apache/hive/src/airflow/providers/apache/hive/sensors/metastore_partition.py` so `MetastorePartitionSensor` passes `mysql_conn_id` to `SqlSensor` as `conn_id` and owns the metastore partition SQL. - Changed `poke()` to split `schema.table` input at runtime and pass `table`, `schema`, and `partition_name` through `SqlSensor.parameters`. - Expanded `SqlSensor` template fields while preserving `partition_name`, `table`, and `schema` templating. - Updated `providers/apache/hive/tests/unit/apache/hive/sensors/test_metastore_partition.py` to cover the documented constructor, schema/table splitting, and parameterized SQL call. - Updated the existing Hive metastore sensor test setup to use `mysql_conn_id`. --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [ ] Yes (please specify the tool below) <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
