dabla commented on code in PR #69564: URL: https://github.com/apache/airflow/pull/69564#discussion_r3550907554
########## providers/microsoft/azure/src/airflow/providers/microsoft/azure/fs/msgraph.py: ########## @@ -27,6 +27,55 @@ schemes = ["msgraph", "sharepoint", "onedrive", "msgd"] +#: Default scope requested when fetching a certificate-based access token. +#: Matches ``KiotaRequestAdapterHook.DEFAULT_SCOPE``. +DEFAULT_SCOPE = "https://graph.microsoft.com/.default"; + + +def _get_certificate_token( Review Comment: NIT: Maybe we should create a module level factory method in `msgraph `hook module which returns a `CertificateCredential` and have the get_credentials method in KiotaRequestAdapterHook and this module call it, that way we avoid code duplication. For the rest looking good to me, just need to address static checks errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
