dabla commented on code in PR #64643:
URL: https://github.com/apache/airflow/pull/64643#discussion_r3551828973
##########
providers/samba/src/airflow/providers/samba/hooks/samba.py:
##########
@@ -325,12 +356,22 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]:
def get_connection_form_widgets(cls) -> dict[str, Any]:
"""Return connection widgets to add to connection form."""
from flask_babel import lazy_gettext
- from wtforms import StringField
+ from wtforms import SelectField, StringField
return {
"share_type": StringField(
label=lazy_gettext("Share Type"),
description="The share OS type (`posix` or `windows`). Used to
determine the formatting of file and folder paths.",
default="posix",
- )
+ ),
+ "auth_protocol": SelectField(
Review Comment:
Seems there was a gap in the static check not catched in this PR, so I
created a follow-up [PR](https://github.com/apache/airflow/pull/69655) for the
static check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
