pierrejeambrun commented on code in PR #68171: URL: https://github.com/apache/airflow/pull/68171#discussion_r3552901987
########## airflow-core/src/airflow/ui/src/layouts/Details/Graph/utils/manualLayoutStore.ts: ########## @@ -0,0 +1,116 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import type { GraphNode } from "./manualLayout"; + +export type ManualLayoutViewport = { + readonly x: number; + readonly y: number; + readonly zoom: number; +}; + +export type ManualLayoutState = { + readonly isManualLayout: boolean; + readonly manualEdgeNodeIds: Set<string>; + readonly manualNodes: Array<GraphNode>; + readonly viewport?: ManualLayoutViewport; +}; + +const keySeparator = "\0"; +const manualLayoutStates = new Map<string, ManualLayoutState>(); +const pendingClearTimers = new Map<string, ReturnType<typeof setTimeout>>(); + +export const getManualLayoutKey = ({ dagId, runId = "" }: { dagId: string; runId?: string }) => Review Comment: Layer 2 — the reconcile effect (removable by deriving). The effect at line 235 only exists because the store holds whole node objects (manualNodes) that then drift from fresh ELK output and have to be merged back. Store position deltas instead — Map<nodeId, {x, y}> of what the user dragged — and derive the rendered nodes at render time: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
