uptothetop opened a new pull request, #69668:
URL: https://github.com/apache/airflow/pull/69668
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
## Context & Motivation
During the migration to Airflow 3, the get_uri() method was removed from the
base Connection object. However, the SQL provider's DbApiHook was still relying
on connection.get_uri() to construct connection strings and resolve dataset
authorities for OpenLineage.
As a result, OpenLineage Column-Level Lineage (CLL) was completely broken
for operators that inherit from BigQueryToSqlBaseOperator and DbApiHook (such
as BigQueryToMsSqlOperator, BigQueryToMySqlOperator, and
BigQueryToPostgresOperator). When these operators attempted to parse the
dataset namespace, they crashed with an AttributeError on the connection object.
## Changes made:
Refactored DbApiHook.get_uri() to construct the URI manually by reading the
host, login, password, port, schema, and extra attributes directly from the
Connection object, identical to how Airflow 2's Connection class used to do it.
Refactored DbApiHook.get_openlineage_authority_part() to extract the
hostname and port directly from the connection properties instead of calling
urlparse(connection.get_uri()).
This fully restores OpenLineage CLL functionality for all SQL-based
operators in Airflow 3 without depending on deprecated Connection methods.
## Testing Done
Verified that calling DbApiHook().get_uri() no longer raises an
AttributeError when provided a mock Airflow 3 Connection.
Ran a local end-to-end test using SQLExecuteQueryOperator with
split_statements=True (executing a CREATE TABLE AS SELECT query against
Postgres) in a Breeze environment.
Verified in Marquez that OpenLineage successfully intercepted the query and
accurately emitted the Column-Level Lineage mapping the source table columns to
the target table columns.
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes (please specify the tool below)
Generated-by: JetSki
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
