shivaam commented on PR #68961: URL: https://github.com/apache/airflow/pull/68961#issuecomment-4928368602
> IMHO, this looks like it is working how I would expect it to work. I know there is still some discussion on whether this is the right approach, so I'll let that discussion play out before approving. > > Also, looks like a merge conflict needs to be resolved. @ferruzzi Thanks for the review. I will resolve the current merge conflict by rebasing the migration onto the latest 3.4.0 migration head. One note: since this PR adds a migration, this kind of conflict may keep coming back whenever another migration lands on main first. To avoid churn, would it be okay to get the functional/design review settled first, and then I can do one final rebase of the migration metadata right before merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
