seanghaeli opened a new pull request, #69682:
URL: https://github.com/apache/airflow/pull/69682
The `example_neptune_analytics` system test previously created and deleted
its own IAM role (`create_neptune_import_role` / `delete_neptune_import_role`)
for Neptune Analytics to assume when reading the import data from S3.
Per review feedback, system tests should not create IAM roles. The role is
now provisioned externally (in the system-test infrastructure) and its ARN is
fetched via
`SystemTestContextBuilder().add_variable("NEPTUNE_IMPORT_ROLE_ARN")` and passed
to `NeptuneStartImportTaskOperator` and `NeptuneCreateGraphWithImportOperator`.
This follows the established pattern in `example_datasync.py` /
`example_comprehend.py` (`ROLE_ARN`).
Changes:
- Add `NEPTUNE_IMPORT_ROLE_ARN_KEY` external variable via `add_variable`.
- Remove the `create_neptune_import_role` / `delete_neptune_import_role`
tasks, the trust/inline policy JSON, the `json`/`time` imports, and the 60s
IAM-consistency sleep.
- Pass the externally-provided ARN to the two import operators and drop the
role tasks from the DAG `chain`.
<!-- Draft: infra that creates the role + passes the ARN parameter lands
separately and must be deployed first. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
