bugraoz93 commented on code in PR #68298:
URL: https://github.com/apache/airflow/pull/68298#discussion_r3562552207
##########
providers/sftp/src/airflow/providers/sftp/hooks/sftp.py:
##########
@@ -51,6 +52,14 @@
CHUNK_SIZE = 64 * 1024 # 64KB
+class SFTPOperation:
+ """SFTP operation constants."""
Review Comment:
This is still not enum
##########
providers/sftp/docs/index.rst:
##########
@@ -104,7 +104,12 @@ PIP package Version
required
``apache-airflow`` ``>=2.11.0``
``apache-airflow-providers-ssh`` ``>=4.0.0``
``apache-airflow-providers-common-compat`` ``>=1.12.0``
+<<<<<<< HEAD
``paramiko`` ``>=4.0.0,<5.0.0``
+=======
+``paramiko`` ``>=3.5.1,<4.0.0``
+``asgiref`` ``>=3.5.2``
+>>>>>>> 423ca853f4 (Add deferrable mode to SFTPOperator)
Review Comment:
Still remaining conflict
##########
providers/sftp/pyproject.toml:
##########
@@ -63,7 +63,13 @@ dependencies = [
"apache-airflow>=2.11.0",
"apache-airflow-providers-ssh>=4.0.0", # use next version
"apache-airflow-providers-common-compat>=1.12.0",
+<<<<<<< HEAD
"paramiko>=4.0.0,<5.0.0",
+=======
+ # TODO: Bump to >= 4.0.0 once
https://github.com/apache/airflow/issues/54079 is handled
+ "paramiko>=3.5.1,<4.0.0",
+ "asgiref>=3.5.2",
Review Comment:
Still 2022 version
##########
providers/sftp/pyproject.toml:
##########
@@ -63,7 +63,13 @@ dependencies = [
"apache-airflow>=2.11.0",
"apache-airflow-providers-ssh>=4.0.0", # use next version
"apache-airflow-providers-common-compat>=1.12.0",
+<<<<<<< HEAD
"paramiko>=4.0.0,<5.0.0",
+=======
+ # TODO: Bump to >= 4.0.0 once
https://github.com/apache/airflow/issues/54079 is handled
+ "paramiko>=3.5.1,<4.0.0",
+ "asgiref>=3.5.2",
+>>>>>>> 423ca853f4 (Add deferrable mode to SFTPOperator)
Review Comment:
Here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
