bujjibabukatta commented on PR #69752: URL: https://github.com/apache/airflow/pull/69752#issuecomment-4946243672
Hi @nailo2c Thanks for the review! I actually went and traced through it before replying instead of just saying "should be fine." Deserialize is untouched, only serialize changed, so anything already sitting in the db from old runs deserializes exactly the same as before, no breakage there. Also checked where this actually gets used (trigger failure handling, xcom etc) and nothing depends on the old broken args shape. The only real difference is the error message itself is correct now instead of showing up wrapped in a weird extra tuple, which was the whole bug. Threw in a newsfragment too so it shows up in release notes. Happy to add more tests if you've got a specific case in mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
