korex-f commented on PR #66633: URL: https://github.com/apache/airflow/pull/66633#issuecomment-4950798335
Addressed all outstanding review comments: - Reverted unrelated changes in `_handle_request` (GetXComCount ordering and send_msg parameter style) - Restored the dropped TODO comment in `_configure_logging` - Used walrus operator for `load_remote_log_handler()` check - Added `hasattr(handler, "close")` guard in `_close_remote_log_handler` to avoid mypy error after reverting the RemoteLogIO protocol change - Reverted all provider and shared/logging changes per @jason810496 guidance, this PR now touches only supervisor.py and log.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
