ashb commented on code in PR #67947:
URL: https://github.com/apache/airflow/pull/67947#discussion_r3569137585
##########
airflow-ctl/src/airflowctl/ctl/cli_config.py:
##########
@@ -602,7 +627,7 @@ def _create_arg_for_non_primitive_type(
arg_type=self._python_type_from_string(annotation),
arg_action=argparse.BooleanOptionalAction if
annotation is bool else None, # type: ignore
arg_help=f"{field} for {parameter_key} operation",
- arg_default=False if annotation is bool else None,
+ arg_default=None,
Review Comment:
Ah right, taking the default from the API makes some sense.
For what it's worth then, rather than, rather using None as not set, I'd
rather we used an explicit NotSet / ARG_NOT_SET sentinel value. I don't know if
we do that elsewhere in the airflowctl, but we do have that elsewhere in
airflow codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
