shivaam commented on code in PR #69295: URL: https://github.com/apache/airflow/pull/69295#discussion_r3569481103
########## task-sdk/src/airflow/sdk/coordinators/node/coordinator.py: ########## @@ -45,6 +46,34 @@ BUNDLE_FILENAME = "bundle.mjs" METADATA_FILENAME = "airflow-metadata.yaml" +EMBEDDED_METADATA_MARKER = b"//# airflowMetadata=" +# Metadata sits on the bundle's first line; a bounded read is enough. +EMBEDDED_METADATA_HEAD_BYTES = 1 << 20 Review Comment: I prefer this const EMBEDDED_METADATA_HEAD_BYTES = 1024 * 1024; ########## task-sdk/src/airflow/sdk/coordinators/node/coordinator.py: ########## @@ -45,6 +46,34 @@ BUNDLE_FILENAME = "bundle.mjs" METADATA_FILENAME = "airflow-metadata.yaml" +EMBEDDED_METADATA_MARKER = b"//# airflowMetadata=" +# Metadata sits on the bundle's first line; a bounded read is enough. +EMBEDDED_METADATA_HEAD_BYTES = 1 << 20 Review Comment: I prefer this EMBEDDED_METADATA_HEAD_BYTES = 1024 * 1024; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
