shahar1 commented on code in PR #69823:
URL: https://github.com/apache/airflow/pull/69823#discussion_r3572606767
##########
providers/google/tests/system/google/cloud/vertex_ai/example_vertex_ai_feature_store.py:
##########
@@ -127,7 +125,7 @@
project_id=PROJECT_ID,
location=REGION,
feature_online_store_id=FEATURE_ONLINE_STORE_ID,
-
feature_online_store=FeatureOnlineStore(optimized=FeatureOnlineStore.Optimized()),
+ feature_online_store={"optimized": {}}, # type: ignore[arg-type]
Review Comment:
`# type: ignore[arg-type]` will leak into the usage example in the docs, is
it possible to avoid it?
##########
providers/google/tests/unit/google/cloud/hooks/vertex_ai/test_feature_store.py:
##########
@@ -27,6 +27,7 @@
Review Comment:
Could we prevent regressions by asserting on `sys.modules`? (to ensure that
no one re-adds the problematic import)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
