bbovenzi commented on code in PR #69741:
URL: https://github.com/apache/airflow/pull/69741#discussion_r3573979511
##########
airflow-core/newsfragments/69741.bugfix.rst:
##########
Review Comment:
Dont need a newsfragment
##########
airflow-core/src/airflow/ui/src/queries/useParamStore.ts:
##########
@@ -45,75 +45,180 @@ type FormStore = {
conf: string;
disabled: boolean;
initialParamDict: ParamsSpec;
+ initParamsDictFromConf: (newParamsDict: ParamsSpec) => void;
+ mergeParamUpdatesIntoConf: boolean;
paramsDict: ParamsSpec;
+ paramsDictSnapshot: ParamsSpec;
setConf: (confString: string) => void;
setDisabled: (disabled: boolean) => void;
setInitialParamDict: (newParamsDict: ParamsSpec) => void;
+ setMergeParamUpdatesIntoConf: (mergeParamUpdatesIntoConf: boolean) => void;
Review Comment:
Could we try to simplify or at least document the variables and the logic
flow here. It's hard to understand what a paramsDictSnapshot or
setMergeParamUpdatesIntoConf mean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
